Tooltip: Show full selector path. (#371) #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madskristensen
added a commit
that referenced
this pull request
Mar 31, 2014
Tooltip: Show full selector path. (#371)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #371. Works fine for LESS.
For SCSS, even the hacky solution doesn't guarantee if all selectors would be mapped to the source (eventually we need to match the selector name which bring us back to square 1: the reason we chose source-map over our manual LessDocument/ScssDocument approach).
FWIW, its the issues with libsass, (the backbone of node-sass, which we are using). However, the original sass gem generates correct source maps. See sass/libsass#324 (comment).
@madskristensen, this PR is isolated from the previous one (its coming from separate branch). I have made changes in (two) separate files. It can be merged for v2 without breaking anything. 🏁