Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CoffeeScript: Wrap generated JS option is reversed #480

Closed
mohd-akram opened this issue Jan 13, 2014 · 8 comments
Closed

CoffeeScript: Wrap generated JS option is reversed #480

mohd-akram opened this issue Jan 13, 2014 · 8 comments

Comments

@mohd-akram
Copy link

Setting the "Wrap generated JavaScript files on save" option to True causes it to not wrap the file while setting it to False does.

Also, issue #387 should be reopened.
@SLaks
Copy link
Collaborator

SLaks commented Jan 13, 2014

I was actually just about to check whether that was the case, because I noticed the setting looked wrong when updating the settings code.

Thanks!

@SLaks
Copy link
Collaborator

SLaks commented Jan 13, 2014

What should that setting default to? I assume true.

@SLaks
Copy link
Collaborator

SLaks commented Jan 13, 2014

When you tested it, did you have the LESS source map option checked?
The old code checked the wrong option.

If you didn't have that checked, I just fixed it.

@mohd-akram
Copy link
Author

The LESS source map option was set to False.

@SLaks
Copy link
Collaborator

SLaks commented Jan 13, 2014

If you set it to true, does it work for CoffeeScript?

@mohd-akram
Copy link
Author

That has no effect. The option remains reversed.

SLaks added a commit to SLaks/WebEssentials2013 that referenced this issue Jan 13, 2014
@SLaks
Settings: Start porting settings usage
314da37 
About 1/4th done.
Also correct some usages & properties.
Fixes madskristensen#480, madskristensen#387
@SLaks
Copy link
Collaborator

SLaks commented Jan 13, 2014

I was asking whether setting that fixes #387.
It certainly won't fix the reversal; that was a simple mistake that I just fixed.

@mohd-akram
Copy link
Author

Ah, sorry. Yes, it does fix it.

SLaks added a commit to SLaks/WebEssentials2013 that referenced this issue Jan 14, 2014
@SLaks
Settings: Start porting settings usage
ec193da 
About 1/4th done.
Also correct some usages & properties.
Fixes madskristensen#480, madskristensen#387
@madskristensen madskristensen mentioned this issue Jan 17, 2014
Closed
SLaks added a commit to SLaks/WebEssentials2013 that referenced this issue Jan 21, 2014
@SLaks
Settings: Start porting settings usage
a2e71d5 
About 1/4th done.
Also correct some usages & properties.
Fixes madskristensen#480, madskristensen#387
SLaks added a commit to SLaks/WebEssentials2013 that referenced this issue Jan 22, 2014
@SLaks
Settings: Start porting settings usage
b597ba2 
About 1/4th done.
Also correct some usages & properties.
Fixes madskristensen#480, madskristensen#387
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SLaks @mohd-akram