Add delete_groups API to AdminClient. (no-op in simulation)
#235
+40
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xxchan <xxchan22f@gmail.com>
a61adf3 to
d2b9fbb
Compare
|
👀 |
|
Looks like an unrelated failure. |
kwannoel
approved these changes
Jan 9, 2025
|
Hmm not sure what's the root cause, opened an issue: #236. |
|
Maybe skip the test first in your PR @xxchan? |
|
Another broken test |
|
@kwannoel Can you publish the new version to crates.io? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needed by risingwavelabs/risingwave#20065
Signed-off-by: xxchan xxchan22f@gmail.com