-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vs2013 solution #59
vs2013 solution #59
Conversation
I'm guessing that you set the SafeSEH flag to support the Assembly optimizations, in that case I would recommend disabling the assembly optimizations as the Windows version of those optimizations is broken (See #41). You can also make the assembly code SEH safe by adding a flag to the compilation there. The only other option I could think of would be that you compile for x64. In that case SafeSEH is default and setting the flag is an error. But that is no reason to disable it for x86. |
+1 for adding |
Mix of fixes and improvements
There are many Visual Studio pull requests. Can someone who is able to test them across versions of Visual Studio merge them into a single pull request? Also please test it with the latest zlib develop branch here on github, and account for functions that have been added since 1.2.8. Thank you. |
See #182 which is based from #167. Other than that it also Provides some other fixes to the definition file and the resource script for the version info resource. The export Definition file was also fixed in it for all of the Project files and includes VS2013 for those who still use it. It targets the latest Develop branch though. |
Please see zlib 1.2.9 for updated vstudio support. Please create new issues or new pull requests if there are problems or desired behaviors against that version. Thanks. |
hi!
i added a vs2013 solution to contrib/vstudio/vc12.
i had to make 2 changes:
maybe this is helpful for windows users.
i tested on win 8.1 with visual studio pro 12.0.21005.1.
thanks!
best regards
max