Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with django-storages using s3 #52

Open
blackwood opened this issue Jun 17, 2019 · 1 comment
Open

Incompatibility with django-storages using s3 #52

blackwood opened this issue Jun 17, 2019 · 1 comment

Comments

@blackwood
Copy link

The extension is incredibly useful. One note: I had to extend the GoogleMapsAddressWidget class so that I could get the file paths correct for my setup using s3 for static assets. I essentially added the django-storages setting into the path.

settings.AWS_S3_CUSTOM_DOMAIN + settings.STATIC_URL + 'django_google_maps/js/google-maps-admin.js',

But I wonder if there's not a way that would handle this automatically, since the other static admin files (for example the ones included with Django) seem to write the path properly.

@madisona
Copy link
Owner

I'd be happy to review a pull request if there is a more generic way to accomplish what you are trying to do. I don't know enough about your situation, but is there a reason your settings.STATIC_URL doesn't or couldn't include the AWS_S3_CUSTOM_DOMAIN already?

dlenskyi pushed a commit to dlenskyi/django-google-maps that referenced this issue Oct 19, 2022
refactoring oauth2, permissions, conditions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants