Fix for unreachable devices, Ap devices and unmanaged devices backup #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madhansansel
reviewed
Aug 5, 2024
| self.log("Length of the device list fetched from the API 'get_device_list' is {0}".format(str(device_list)), "INFO") | ||
| if len(device_list) == 0: | ||
| original_dev_len = len(device_list) | ||
| if original_dev_len == 0: | ||
| msg = "Couldn't find any devices in the inventory that match the given parameters." |
There was a problem hiding this comment.
msg = "No devices found in the inventory matching the given parameters."
| for dev_info in device_list: | ||
| if dev_info.get("collectionStatus") != "Managed": | ||
| msg = "Device backup of device with IP address {0} \ | ||
| is not possible due to collection status not being in Managed state".format(dev_info.get("managementIpAddress")) |
| changed_dev_list.append(dev_info) | ||
|
|
||
| if len(changed_dev_list) == 0: | ||
| msg = "No device IDs got collected either due to devices \ |
There was a problem hiding this comment.
("No device IDs were collected because the devices are either Unified APs, "
"not in the Managed state, or not reachable.")
| msg = "Couldn't find any devices in the inventory that match the given parameters." | ||
| self.log(msg, "CRITICAL") | ||
| self.module.fail_json(msg=msg) | ||
|
|
||
| dev_id_list = [id.get("id") for id in device_list] | ||
| changed_dev_list = [] |
There was a problem hiding this comment.
Can we say valid_devices instead of changed_dev_list?
If you feel 'changed_dev_list' makes more sense, then ignore this comment.
There was a problem hiding this comment.
valid_devices makes more sense
| self.log(msg, "CRITICAL") | ||
| self.module.fail_json(msg=msg) | ||
|
|
||
| dev_id_list = [id.get("id") for id in changed_dev_list] |
There was a problem hiding this comment.
device_ids instead of dev_id_list
| self.module.fail_json(msg=msg) | ||
|
|
||
| dev_id_list = [id.get("id") for id in changed_dev_list] | ||
| dev_len = len(dev_id_list) |
There was a problem hiding this comment.
valid_device_count instead of dev_len... as we count the number of valid devices
| self.module.fail_json(msg=msg) | ||
|
|
||
| dev_id_list = [id.get("id") for id in changed_dev_list] | ||
| dev_len = len(dev_id_list) | ||
| self.log("Device Ids list collected is {0}".format(dev_id_list), "INFO") |
| self.log("Device Ids list collected is {0}".format(dev_id_list), "INFO") | ||
| self.log("Backup of {0} devices out of {1} devices is possible".format(dev_len, original_dev_len), "INFO") | ||
| return dev_id_list |
madhansansel
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default Code Review Template
Description
Added the fix where devices being AP or being in unmanaged state or being in unreachable state, won't be going for the device config backup. For the same, I added a few conditions by looping through the device list retrieved via 'get device list' API.
Type of Change
Checklist
Ansible Best Practices
ansible-vaultor environment variables)Documentation