Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request contains two changes:
1) Replace SignalSlot implementation by Events
There was a remaining SignalSlot implementation left, which did not work in TYPO3 12 anymore and resulted in an error, because
\TYPO3\CMS\Extbase\SignalSlot\Dispatcher
does not exist anymore.Looks like the SignalSlot implementation did not work for several TYPO3 reasons. Because the signals already have been removed in the core long time ago. But nevertheless, it's good to have the feature brought back to have correct dimensions for uploaded files.
2) Fix composer constraint
"typo3/cms-core": ">=11.5.0"
says "any version since 11.5.0, no matter if it is TYPO3 12, TYPO 13 or TYPO3 99 ... I changed it to the more precise constraint"typo3/cms-core": "^11.5 || ^12.0"
which limits it to TYPO3 11.. or 12.. - the same as it is mentioned inext_emconf.php
.