Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TYPO3 12 compatibility #40

Merged
merged 3 commits into from
Jan 18, 2024
Merged

Conversation

koehnlein
Copy link
Contributor

@koehnlein koehnlein commented Jan 17, 2024

This merge request contains two changes:

1) Replace SignalSlot implementation by Events

There was a remaining SignalSlot implementation left, which did not work in TYPO3 12 anymore and resulted in an error, because \TYPO3\CMS\Extbase\SignalSlot\Dispatcher does not exist anymore.

Looks like the SignalSlot implementation did not work for several TYPO3 reasons. Because the signals already have been removed in the core long time ago. But nevertheless, it's good to have the feature brought back to have correct dimensions for uploaded files.

2) Fix composer constraint

"typo3/cms-core": ">=11.5.0" says "any version since 11.5.0, no matter if it is TYPO3 12, TYPO 13 or TYPO3 99 ... I changed it to the more precise constraint "typo3/cms-core": "^11.5 || ^12.0" which limits it to TYPO3 11.. or 12.. - the same as it is mentioned in ext_emconf.php.

@tmotyl
Copy link
Member

tmotyl commented Jan 17, 2024

Hi Albrecht,
Thanks for the PR!
Please remove the change to composer constraints, as it makes testing the extension with main (upcomming v13) annoying.
We can mention in readme in which TYPO3 versions it was tested, but I would not add a hard limit to v12 only.

@koehnlein
Copy link
Contributor Author

@tmotyl I did it.

I don't think, it's a good idea. But your repository - your rules ;-)

@tmotyl
Copy link
Member

tmotyl commented Jan 18, 2024

Thanks
Have you tested the changes in v11 too? or is this change only for v12 ?

@koehnlein
Copy link
Contributor Author

Manually tested in TYPO3 11 and 12

@tmotyl tmotyl merged commit 6df32d4 into macopedia:master Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants