Remove duplicate is_tty check

include/mwr/core/utils.h

@@ -79,8 +79,6 @@ size_t fd_seek_end(int fd, off_t pos);
 int fd_dup(int fd);
 int fd_pipe(int fds[2]);
 
-bool fd_isatty(int fd);
-
 double timestamp();
 u64 timestamp_ms();
 u64 timestamp_us();

src/mwr/core/utils.cpp

@@ -532,7 +532,7 @@ size_t fd_read(int fd, void* buffer, size_t buflen) {
     size_t numread = 0;
 
 #ifdef MWR_MSVC
-    if (fd == STDIN_FDNO && fd_isatty(fd))
+    if (fd == STDIN_FDNO && _isatty(fd))
         return msvc_read_console(ptr, buflen);
 #endif
 
@@ -623,14 +623,6 @@ int fd_pipe(int fds[2]) {
 #endif
 }
 
-bool fd_isatty(int fd) {
-#ifdef MWR_MSVC
-    return _isatty(fd);
-#else
-    return isatty(fd);
-#endif
-}
-
 using timestamp_clock = chrono::steady_clock;
 static auto g_start = timestamp_clock::now();
 

src/mwr/logging/publishers/terminal.cpp

@@ -15,11 +15,11 @@ namespace mwr {
 namespace publishers {
 
 static bool supports_colors(bool use_cerr) {
-    int fd = use_cerr ? mwr::STDERR_FDNO : mwr::STDOUT_FDNO;
-    if (!mwr::fd_isatty(fd))
+    int fd = use_cerr ? STDERR_FDNO : STDOUT_FDNO;
+    if (!is_tty(fd))
         return false;
 
-    auto env = mwr::getenv("TERM");
+    auto env = getenv("TERM");
     if (!env)
         return false;
 

test/core/utils.cpp

@@ -167,8 +167,6 @@ TEST(utils, fd_io) {
     ASSERT_EQ(fd_read(fd, buffer, n), n);
     EXPECT_STREQ(text, buffer);
 
-    EXPECT_FALSE(fd_isatty(fd));
-
     fd_close(fd);
     std::filesystem::remove_all("testfile");
 }