Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pe.parse: added header signature check #286

Merged
merged 1 commit into from
Oct 17, 2021
Merged

pe.parse: added header signature check #286

merged 1 commit into from
Oct 17, 2021

Conversation

skdltmxn
Copy link
Contributor

I added header signature check logics for PE binaries.
Now PE::parse does not panic but returns error::Error::Malformed if either DOS or PE header has incorrect signature value.
I also added two tests.

This PR fixes #283

m4b
m4b approved these changes Oct 17, 2021
View reviewed changes
Copy link
Owner

@m4b m4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow I thought we had already checked this, thanks for the fix!

@m4b m4b merged commit 7d4e02c into m4b:master Oct 17, 2021
@skdltmxn skdltmxn deleted the pe_header_verify branch October 17, 2021 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4b m4b m4b approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

panicked at 'attempt to subtract with overflow'
2 participants
@skdltmxn @m4b