Public utils + more examples #116
Conversation
|
Also renamed CLR -> CLI to match documentation
|
See official microsoft pe format documentation it names CLR |
|
@Pzixel In my opinion, to make changes that are consistent with the documentation and ESMA-335, you should send an issue to https://github.com/MicrosoftDocs, and then, when it is approved, change it in this repo. |
|
Yep, but ECMA-335 conserns CLI specification (not .Net as you said) and this header is specifically CLI header, so it must be the most competent in this question. However, you are right that docs should be updated. I'm creating an issue. However, I don't see corresponding repository for it. |
|
So what is the resolution (if any) for CLR/CLI data directory naming ? I would prefer to not make a breaking change and I used the original documentation that @kgv linked. We can always update it in a later PR if need be. And thanks for both your investigations here! |
|
@m4b I created a PR in MS documentation repo, however, it keeps silent. It looks like it takes 2-3 days until someone react on it. I can revert this change if you wish, OTOH I have strong feeling that CLI specification is more compenent in this question. |
|
I reverted rename change. P.S. I wonder why you keep rust 1.20. It doesn't make sense to me since rust is pretty well backward compatible. |
|
Ping? |
src/pe/utils.rs
Outdated
| @@ -74,3 +76,24 @@ pub fn try_name<'a>(bytes: &'a [u8], rva: usize, sections: &[section_table::Sect | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| pub fn get_data<'a, T>(bytes: &'a [u8], sections: &[section_table::SectionTable], directory: &DataDirectory, file_alignment: u32) -> Result<T, DataDirectoryConversionError> | |||
There was a problem hiding this comment.
This seems like it belongs as a method in DataDirectories ?
There was a problem hiding this comment.
I'm not sure, because it belongs to SectionTable as well.. Utils is the good place for this imo
|
Pong? |
Fixes #115