Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migration to uv #429

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

migration to uv #429

wants to merge 10 commits into from

Conversation

hirosassa
Copy link
Collaborator

What is this PR

SSIA
I migrated to uv from poetry for better developer experience.

tox.ini Outdated
coverage run
coverage xml
coverage report
{envpython} -m pytest -n auto --cov=gokart --cov-report=xml test -vv
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just simplified


[tool.ruff]
line-length = 160
exclude = ["venv/*", "tox/*"]
exclude = ["venv/*", "tox/*", "examples/*"]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From v0.6 of ruff supports jupyter notebook files. Currently ignored

"mypy",
"pytest",
"pytest-cov",
"pytest-xdist",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added for faster testing

@hiro-o918
Copy link
Contributor

LGTM!

@kitagry @Hi-king
We must update repo settings to update required CI pipelines because of changes about environment matrixes.

Copy link
Collaborator

@yokomotod yokomotod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hirosassa I love uv !

.github/workflows/format.yml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@yokomotod
Copy link
Collaborator

[question]

ruff format changes just caused by ruff's version up, not uv migration ?

tox.ini Outdated Show resolved Hide resolved
@hirosassa
Copy link
Collaborator Author

@hiro-o918

We must update repo settings to update required CI pipelines
I updated by myself 👍

@hirosassa
Copy link
Collaborator Author

@yokomotod > ruff format changes just caused by ruff's version up, not uv migration ?
Yes, it is. I should separate this kind of change, but the changes on this PR will be more complex, so I'd like to include them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants