Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle default type for DateMinuteParameter #396

Merged
merged 1 commit into from
Sep 19, 2024
Merged

fix: handle default type for DateMinuteParameter #396

merged 1 commit into from
Sep 19, 2024

Conversation

hiro-o918
Copy link
Contributor

What

  • fixes mypy error: luigi.DateMinuteParameter #395
  • before this PR, default argument is assumed to be positioned on the first argument
    • but some paramters like DateMinuteParmeter not
  • This PR aims to find the position of default argument by the keyword name

kitagry
kitagry approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@kitagry kitagry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kitagry kitagry merged commit 92f6b0d into master Sep 19, 2024
5 checks passed
@kitagry kitagry deleted the fix/#395 branch September 19, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kitagry kitagry kitagry approved these changes

@hirosassa hirosassa Awaiting requested review from hirosassa

@yokomotod yokomotod Awaiting requested review from yokomotod

@ujiuji1259 ujiuji1259 Awaiting requested review from ujiuji1259

@mski-iksm mski-iksm Awaiting requested review from mski-iksm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mypy error: luigi.DateMinuteParameter
2 participants
@hiro-o918 @kitagry