Add complete_check_at_run parameter #333
Merged
+83
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yokomotod
reviewed
Nov 10, 2023
Comment on lines
+93
to
+94
| if self.complete_check_at_run: | ||
| self.run = task_complete_check_wrapper(run_func=self.run, complete_check_func=self.complete) |
There was a problem hiding this comment.
@mski-iksm What will the log look like?
I'm wondering if we should add a log that shows what I skipped.
There was a problem hiding this comment.
81ddaaa to
115280d
Compare
Hi-king
approved these changes
Nov 21, 2023
|
@mski-iksm THX! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
TaskOnKart.complete_check_at_run is a parameter to control whether to check completed cache file existence at TaskOnKArt.run().
If complete_check_at_run==True, when the worker attempt to run the task, it will check the cache file existence, and if exists, run() will be skipped.
Why is this needed?
In the original code, complete check is only evaluated at task scheduling, which is at the very beginning.
However, cache status may change when it comes to run().
This often happens when jobs in multiple nodes runs the same task.
When node1 and node2 runs the same task, the first finished node will create the completed cache, but the other node may rerun the task and recreate the same cache file.
It is okay to run same task again, but it is not efficient.
To prevent running the completed task again, I've implemented TaskOnKart.complete_check_at_run option.