Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag editor and explorer fixes/changes #677

Open
reskyner opened this issue Nov 17, 2021 · 3 comments
Open

Tag editor and explorer fixes/changes #677

reskyner opened this issue Nov 17, 2021 · 3 comments

Comments

@reskyner
Copy link

reskyner commented Nov 17, 2021

  • CSS changes for tag buttons (reduce spacing): jss154 {padding-bottom: 0px; }
  • "Tag selector"
    • renamed to "Hit List Filter"
    • Change 'clear selection' to 'unselect' and use same icon as 'select all'
    • Change 'Forum' to 'Discussion'
  • Add an embedded resizable pane named "Tag details"
    • Goes above "Hit List Filter" pane
    • detailed spec below
  • "Tag editor" modal should be renamed "Assign tags",
    • just be for selecting tags (like github 'labels')
    • detailed spec below.
@phraenquex
Copy link
Collaborator

phraenquex commented Nov 17, 2021

For the "Assign tags" modal (previously "Tag Editor")

  • Call it "Assign tags" (image below is wrong)
  • Tag layout exactly like in the Hit Filter (previously: "tag selector")
  • Instead of the arrow, show a check-box, that’s empty when you hover, and checked when you click and the "Assign tags" modal pops up
  • Likewise, the selector check-box on the left of the hit should be selected when the "Assign tags" modal shows, and unselected when it closes.
    • (Red arrow in image below indicates linked behaviour.)
    • If it was selected before the "Assign tags" modal came up, then it should stay selected after modal is closed
  • The tooltip should be white with the tags displayed in same tag shape/colour format as elsewhere
  • The tooltip should stay up when the "Assign tags" modal is displayed, and should fill up with the tags as they're clicked in the "Assign tags" modal
  • If several molecules are selected when tag editor is open, make sure tag edits are applied to whole selection

image

@phraenquex
Copy link
Collaborator

phraenquex commented Nov 17, 2021

For the "Tag Details" pane:

  • Tag icons should behave identical to the tag icons in the "Hit List Filter", behave in the same way, and linked to them: clicking a tag in either pane should select/unselect it in the other pane, and show/hide the hits in the Hit navigator pane.
  • The font sizes matter - same size as tag label
  • Clicking "Edit" should populate the "New tag" fields on the bottom, and replace "Create" with "Save/Delete" buttons
  • "Select hits" should select the check-boxes in the Hit navigator.
  • The spinners next to Tag name/Category/Cereator/Date should do (sort up / sort down / original) in sequence
  • (category) dropdown should not have a category by default (currently it's wrong, it has "Sites" by default)
  • Name - backend should return an actual person name, if at all possible. A userid (probably) is okay if absolutely necessary,
  • In "Category" dropdown, "Forum" -> "Discussion". (@duncanpeacock is this a backend change?)
  • Assign these default colour for each category (colourblind colours from https://colorbrewer2.org/#type=diverging&scheme=RdYlBu&n=4):
    • Sites: #d7191c
    • Series: #fdae61
    • Discussion: #abd9e9
    • Other: #2c7bb6

image

@phraenquex
Copy link
Collaborator

phraenquex commented Nov 17, 2021

For future use, here the powerpoint where I created the mockups
Tag details pane.pptx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants