Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vector-selector view not properly restored (resubmission of #479) #532

Open
phraenquex opened this issue Jan 29, 2021 · 5 comments
Open

Vector-selector view not properly restored (resubmission of #479) #532

phraenquex opened this issue Jan 29, 2021 · 5 comments
Assignees
@ak-m2ms
Labels
bug Something isn't working rel 2.1.7

Comments

@phraenquex
Copy link
Collaborator

I save a view that with compounds show in the vector selector, and some selected.

If I restore the view, neither are the compounds shown in the vector selector, nor are the relevant ones selected.

I see that actions are captured - but the things that they trigger are not properly restored.

On save (goes into this session on staging):
image

Actions at the time:
image

After restore:
image
@phraenquex phraenquex added the bug Something isn't working label Jan 29, 2021
This was referenced Jan 29, 2021
Open
Open
ak-m2ms pushed a commit that referenced this issue Feb 5, 2021
#532 Vector-selector view not properly restored
ad5aa18
ak-m2ms pushed a commit that referenced this issue Feb 8, 2021
#532 Vector-selector view not properly restored
d33e729
@ak-m2ms
Copy link
Collaborator

ak-m2ms commented Feb 9, 2021

Solution in #510.

@teriraj
Copy link
Collaborator

teriraj commented Feb 9, 2021

It is not fixed correctly, please check it again

@teriraj
Copy link
Collaborator

teriraj commented Feb 9, 2021

saved
image
restored
image

@phraenquex
Copy link
Collaborator Author

Fantastic.
I'll add a comment to #441 about having the coloured selections restored as well; I imagine it belongs there.

@phraenquex phraenquex mentioned this issue Feb 9, 2021
Open
ak-m2ms pushed a commit that referenced this issue Feb 9, 2021
#532 Vector-selector view not properly restored
36bf528
@teriraj
Copy link
Collaborator

teriraj commented Feb 10, 2021

fixed

@mwinokan mwinokan moved this to In production (Done) in Fragalysis May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ak-m2ms ak-m2ms

Labels
bug Something isn't working rel 2.1.7
Projects
Fragalysis
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@boriskovar-m2ms @phraenquex @teriraj @ak-m2ms