Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sorting not working in filter modal (RHS) #370

Open
reskyner opened this issue Jun 17, 2020 · 6 comments
Open

Sorting not working in filter modal (RHS) #370

reskyner opened this issue Jun 17, 2020 · 6 comments
Assignees
@boriskovar-m2ms

Comments

@reskyner
Copy link

The sorting isn't working - or if it is, it's extremely confusing.

image
@phraenquex phraenquex mentioned this issue Jun 17, 2020
Open
tibor-postek-m2ms added a commit that referenced this issue Jun 17, 2020
@tibor-postek-m2ms
#370 add not completed fix of filter RHS
e16ccd6
@tibor-postek-m2ms
Copy link

  • show not suitable in result list and mark them with red color. otherwise it will be green color

@phraenquex
Copy link
Collaborator

Bugs:

  • it's not sorting even by the top-most value
  • sliders are wrong when you ifirst open modal
  • priority buttons don't move things up-and-down

Feature:

  • add a "ignore" radio button in the "order" column, so we have up/down/ignore

@boriskovar-m2ms
Copy link
Collaborator

boriskovar-m2ms commented Jun 30, 2020 •
edited
Loading

Support for booleans is broken. We need three value logic - true, false, ignore (both)

boriskovar-m2ms added a commit that referenced this issue Jul 2, 2020
@boriskovar-m2ms
- fixed #391, #367
c88785b 
- work in progress #370
@boriskovar-m2ms boriskovar-m2ms self-assigned this Jul 3, 2020
@boriskovar-m2ms
Copy link
Collaborator

known issue: filter is not applied until it is used for very first time.

boriskovar-m2ms added a commit that referenced this issue Jul 3, 2020
@boriskovar-m2ms
- fixed right hand side sorting and three way logic was bool values w…
9ef2b0f 
…as implemented. #370, #384
@reskyner
Copy link
Author

reskyner commented Jul 8, 2020

New, different issue but related to the behaviour of RHS filter: #403

@reskyner
Copy link
Author

reskyner commented Jul 8, 2020

Another (probably) related bug: #404

boriskovar-m2ms added a commit that referenced this issue Jul 13, 2020
@boriskovar-m2ms @tibor-postek-m2ms
Rhs filter (#411)
0eb143a 
* #371 add total count of molecules into footer of molecule lists

* #371 show warning modal window after click on load full list, that has more than 100 molecules

* #360 add auto center button into molecule lists

* #360 fix centering ligands from right side, fix layout of molecule buttons

* #360 auto focus only first molecule from site 1 in target mode

* #360 uncomment feature to able to select first protein

* #360 change style of centre on molecule button

* #371 change description of alert modal

* #384 add layout of up/down arrows

* #384 move same settings to next/previous compound in LHS

* #384 move same settings to next/previous compound in RHS

* #369 not successful load text values of scores

* #369 show score values in RHS, but cannot open filter

* #369 parse numbers, text and booleans in RHS

* #369 load scores and molecules in one request

* #369 fix bug with opening filter

* #384 new behaviour of buttons to skip

* #390 add dropdown to dataset tab menu header

* #371 add total count of molecules into footer of molecule lists

* #371 show warning modal window after click on load full list, that has more than 100 molecules

* #360 add auto center button into molecule lists

* #360 fix centering ligands from right side, fix layout of molecule buttons

* #360 auto focus only first molecule from site 1 in target mode

* #360 uncomment feature to able to select first protein

* #360 change style of centre on molecule button

* #367 load only first ligand  and protein of first molecule after first loading of target

* #367 load only first ligand  and protein of first molecule after first loading of target

* #369 fix showing score details in filter of RHS

* #369 loading all datasets data in Preview component

* #369 show boolean in filter

* - fixed #391, #367
- work in progress #370

* - fixed right hand side sorting and three way logic was bool values was implemented. #370, #384

* - #401 - fixed not changing molecules when changing the order
- #400 - now in the LHS the rounded values are used for sorting

* -fixed wrong initial order of compounds on the right hand side

* - #402 new approach for downloading the data

* data sets only for compatible targets.
updated readme with instructions when loader and/or backend is changed

* another try to filter out custom datasets

* updated launch.json

Co-authored-by: Tibor Postek <tibor.postek@m2ms.sk>
boriskovar-m2ms pushed a commit that referenced this issue Dec 19, 2023
@mwinokan
Merge pull request #370 from xchem/staging
c8ef4b3 
MS 2023-06-15 #1107 #1109 (#369)
@mwinokan mwinokan moved this to In production (Done) in Fragalysis May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boriskovar-m2ms boriskovar-m2ms

Labels
None yet
Projects
Fragalysis
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@reskyner @boriskovar-m2ms @phraenquex @tibor-postek-m2ms