Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Application] It is not possible to close filter window when Predefined filter is selected #186

Closed
veronikabelusikova opened this issue Mar 13, 2020 · 1 comment · Fixed by #188 or xchem/fragalysis-frontend#146
Closed

[Application] It is not possible to close filter window when Predefined filter is selected #186

veronikabelusikova opened this issue Mar 13, 2020 · 1 comment · Fixed by #188 or xchem/fragalysis-frontend#146
Assignees
@matej-vavrek
Labels
bug Something isn't working

Comments

@veronikabelusikova
Copy link
Collaborator

  1. open filter window
  2. select predefined filter in Hit navigator --> Sort/filter button is disabled
  3. it is not possible to close filter window

user has to select "none" predefined filter to close filter window
@veronikabelusikova veronikabelusikova added the bug Something isn't working label Mar 13, 2020
matej-vavrek added a commit that referenced this issue Mar 13, 2020
@matej-vavrek
#186 disable predefined filter when filter window is open
1436c01
matej-vavrek added a commit that referenced this issue Mar 13, 2020
@matej-vavrek
#186 try to update predefined filter after initialization
be80aaf
matej-vavrek added a commit that referenced this issue Mar 13, 2020
@matej-vavrek
#186 disable predefined filter when filter window is open
51e4f16
matej-vavrek added a commit that referenced this issue Mar 13, 2020
@matej-vavrek
#186 try to update predefined filter after initialization
c0e3fa9
@matej-vavrek matej-vavrek linked a pull request Mar 13, 2020 that will close this issue
fixed possible filter window and predefined filter collision #188
Merged
@matej-vavrek matej-vavrek self-assigned this Mar 13, 2020
@matej-vavrek
Copy link
Collaborator

Predefined filter is disabled when filter window is open now.

@matej-vavrek matej-vavrek mentioned this issue Mar 13, 2020
Merged
tibor-postek-m2ms added a commit that referenced this issue Apr 28, 2020
@tibor-postek-m2ms
#186 fix undefined object
6388c9c
tibor-postek-m2ms pushed a commit that referenced this issue Jun 22, 2020
@reskyner
Merge pull request #186 from m2ms/#363
4823887 
#363
@mwinokan mwinokan moved this to In production (Done) in Fragalysis May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matej-vavrek matej-vavrek

Labels
bug Something isn't working
Projects
Fragalysis
Archived in project
Milestone
No milestone
2 participants
@matej-vavrek @veronikabelusikova