Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix f/e buttons to allow different XCA tag assignments in the same pose #1522

Open
mwinokan opened this issue Sep 23, 2024 · 7 comments
Open
Assignees
Labels
2024-06-14 mint Data dissemination 2 frontend

Comments

@mwinokan
Copy link
Collaborator

@matej-vavrek can you please comment on how difficult it would be to implement the following spec for the Change XCA tags dropdown in the observations modal:

  • When no/all observations are selected: change tag assignment for all observations in the pose
  • When a subset of observations is selected: change tag assignment for just the selected observations

Currently, all observations are retagged regardless of the checkbox states/selection. I anticipate difficulties may arise with the CanonSites, as poses are not allowed to contain observations with different CanonSites, ideally grey out the option to change CanonSites, and show a tooltip/warning that says "Separate observations into multiple poses to change CanonSites"

@matej-vavrek
Copy link
Collaborator

Hmm so basically is to change the behaviour to change tag assignment only to selected observations if there is a selection?
And also to disable/grey out CanonSites in options when there is a selection?

It should not be very difficult if this is the case.

@mwinokan
Copy link
Collaborator Author

@matej-vavrek, yes exactly, thanks for the estimate

@matej-vavrek matej-vavrek moved this from Backlog to In Progress (DEV) in Fragalysis Oct 1, 2024
@matej-vavrek
Copy link
Collaborator

@mwinokan, I have updated my stack. I allowed to change CanonSites if all observations are selected too and I noticed that after changing it that it was not possible to un/select affected tag from Tag list so I also fixed this.

@matej-vavrek matej-vavrek moved this from In Progress (DEV) to Dev Done - Do review (DEV) in Fragalysis Oct 2, 2024
@mwinokan
Copy link
Collaborator Author

Thanks @matej-vavrek. it seems to be working. I am particularly pleased that the UI you built to show different conformer sites works nicely!
Screenshot 2024-10-10 at 10 53 07

@mwinokan mwinokan moved this from Dev Done - Do review (DEV) to QA done in dev.env - move to staging in Fragalysis Oct 10, 2024
@mwinokan mwinokan moved this from QA done in dev.env - move to staging to In staging - assess function vs spec in Fragalysis Oct 14, 2024
@mwinokan
Copy link
Collaborator Author

The feature was working on Matej's stack. @matej-vavrek please merge it to staging

@matej-vavrek
Copy link
Collaborator

@mwinokan, is this all right now, please?

@mwinokan
Copy link
Collaborator Author

Approved in staging

@mwinokan mwinokan moved this from In staging - assess function vs spec to Approved in staging - push to production in Fragalysis Oct 22, 2024
@phraenquex phraenquex moved this from Approved in staging - push to production to In production (Done) in Fragalysis Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2024-06-14 mint Data dissemination 2 frontend
Projects
Status: In production (Done)
Development

No branches or pull requests

2 participants