Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scribble on screenshot in 'submit idea' modal #120

Closed
reskyner opened this issue Feb 25, 2020 · 3 comments · Fixed by #204 or xchem/fragalysis-frontend#146
Closed

Scribble on screenshot in 'submit idea' modal #120

reskyner opened this issue Feb 25, 2020 · 3 comments · Fixed by #204 or xchem/fragalysis-frontend#146
Assignees
@matej-vavrek
Labels
idea New idea submitted by user from feedback form rel 0.3.0

Comments

@reskyner
Copy link

Ability to annotate the captured screenshot when submitting an idea. The modal should also be bigger and expandable
@reskyner reskyner added the idea New idea submitted by user from feedback form label Feb 25, 2020
@phraenquex
Copy link
Collaborator

Priority 1: evaluate whether this is easy to do. If it is, it should be priority.

@matej-vavrek
Copy link
Collaborator

This should not take more than a day top. There are already available libraries for drawing (react including) and it should not be so hard to do without a library too.

matej-vavrek added a commit that referenced this issue Mar 18, 2020
@matej-vavrek
#120 added scribble possibility for report forms (added react-canvas-…
8cdc943 
…draw), try to get only valid email and from username in form, added resizable option for modal

#163 changed "Title" to "Subject"
matej-vavrek added a commit that referenced this issue Mar 18, 2020
@matej-vavrek
#120 changed way of sending image for issue creation
d4ad3c1
matej-vavrek added a commit that referenced this issue Mar 19, 2020
@matej-vavrek
#120 changed canvas draw to be in image full size, updated style of o…
b61104d 
…ptions
matej-vavrek added a commit that referenced this issue Mar 19, 2020
@matej-vavrek
#120 added scribble possibility for report forms (added react-canvas-…
692a964 
…draw), try to get only valid email and from username in form, added resizable option for modal

#163 changed "Title" to "Subject"
matej-vavrek added a commit that referenced this issue Mar 19, 2020
@matej-vavrek
#120 changed way of sending image for issue creation
f3bd011
matej-vavrek added a commit that referenced this issue Mar 19, 2020
@matej-vavrek
#120 changed canvas draw to be in image full size, updated style of o…
c1e7991 
…ptions
@matej-vavrek matej-vavrek linked a pull request Mar 19, 2020 that will close this issue
Scribble screenshot #204
Merged
@matej-vavrek matej-vavrek mentioned this issue Mar 19, 2020
Merged
@matej-vavrek
Copy link
Collaborator

Scribble possibility was added. Modal dialog is currently set to fit at least 960 wide monitor. Modal is not resizable at the moment, but whole screenshot is scrollable.

@mwinokan mwinokan moved this to In production (Done) in Fragalysis May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matej-vavrek matej-vavrek

Labels
idea New idea submitted by user from feedback form rel 0.3.0
Projects
Fragalysis
Archived in project
Milestone
No milestone
4 participants
@reskyner @boriskovar-m2ms @phraenquex @matej-vavrek