Merge remote-tracking branch 'remotes/origin/#449' into allfunctionality

m2ms · Nov 6, 2020 · 25989d9 · 25989d9
2 parents 32c0d52 + 94db501
commit 25989d9
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/js/components/preview/molecule/redux/dispatchActions.js b/js/components/preview/molecule/redux/dispatchActions.js
@@ -390,7 +390,6 @@ export const applyDirectSelection = (stage, stageSummaryView) => (dispatch, getS
   const state = getState();
 
   const directDisplay = state.apiReducers.direct_access;
-  const mol_group_selection = state.selectionReducers.mol_group_selection;
   const fragmentDisplayList = state.selectionReducers.fragmentDisplayList;
   const proteinList = state.selectionReducers.proteinList;
   const complexList = state.selectionReducers.complexList;
@@ -415,6 +414,8 @@ export const applyDirectSelection = (stage, stageSummaryView) => (dispatch, getS
           let proteinCodeModded = mol.protein_code.toLowerCase();
           if (m.exact ? proteinCodeModded === directProteinCodeModded : proteinCodeModded.includes(directProteinNameModded)) {
             let molGroupId = groupId;
+            // Has to be declared here because otherwise we read stale value
+            const mol_group_selection = getState().selectionReducers.mol_group_selection;
             if (!mol_group_selection.includes(parseInt(molGroupId))) {
               let molGroup = mol_group_list.find(g => g.id === parseInt(molGroupId));
               dispatch(selectMoleculeGroup(molGroup, stageSummaryView));