- #1483 - state based rendering is now done

m2ms · Nov 18, 2024 · 228973f · 228973f
1 parent dfd16da
commit 228973f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 17 deletions.
diff --git a/js/components/datasets/redux/dispatchActions.js b/js/components/datasets/redux/dispatchActions.js
@@ -204,22 +204,7 @@ export const addDatasetLigand = (
       representations: representations,
       datasetID: datasetID
     })
-  ).finally(() => {
-    const skipOrientation = false; //state.trackingReducers.skipOrientationChange;
-    if (!skipOrientation) {
-      const ligandOrientation = stage.viewerControls.getOrientation();
-      dispatch(setOrientation(VIEWS.MAJOR_VIEW, ligandOrientation));
-
-      dispatch(appendMoleculeOrientation(getDatasetMoleculeID(datasetID, data?.id), ligandOrientation));
-
-      // keep current orientation of NGL View
-      if (!skipOrientation) {
-        console.count(`Before applying orientation after loading dataset ligand.`);
-        stage.viewerControls.orient(currentOrientation);
-        console.count(`After applying orientation after loading dataset ligand.`);
-      }
-    }
-  });
+  );
 };
 
 export const removeDatasetLigand = (stage, data, colourToggle, datasetID, skipTracking = false) => dispatch => {

diff --git a/js/components/preview/molecule/moleculeView/moleculeView.js b/js/components/preview/molecule/moleculeView/moleculeView.js
@@ -1503,7 +1503,7 @@ const MoleculeView = memo(
                     const tagTypeObject = getTagType(tagCategory);
                     const tagLabel =
                       tagCategory === 'ConformerSites'
-                        ? tagTypeObject.tag_prefix.replace(getTagType('CanonSites')?.tag_prefix, '')
+                        ? tagTypeObject?.tag_prefix.replace(getTagType('CanonSites')?.tag_prefix, '')
                         : tagTypeObject?.tag_prefix;
                     return (
                       <Tooltip