Use FingerprintManager instead of FingerprintManagerCompat (Fix #300) #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m2049r
reviewed
Jun 9, 2018
|
|
||
| return keyguardManager != null && | ||
| return keyguardManager != null && fingerprintManager != null && |
There was a problem hiding this comment.
@0140454 please use brackets around subexpressions: return (keyguardManager != null) && (fingerprintManager != null) && ... for legibility
|
If I merge #297 into master, could you rebase this off that - I am having a hard time figuring out what's right! |
|
@m2049r |
m2049r
approved these changes
Jun 10, 2018
m2049r
pushed a commit
to monerujo-io/aeonwallet
that referenced
this pull request
Jun 11, 2018
crtlib
pushed a commit
to evocodes/loki-android-wallet
that referenced
this pull request
Jun 12, 2018
m2049r
added a commit
to monerujo-io/aeonwallet
that referenced
this pull request
Jun 28, 2018
* spinner tweaks (m2049r#306) * Fix keystore null (m2049r#308) * avoid crash if input to large * avoid NPE if wallet key not found * Use FingerprintManager instead of FingerprintManagerCompat (Fix m2049r#300) (m2049r#302) * show correct amount for pending tx (m2049r#309) * accounts (m2049r#312) * Inform user the progress or result of opening wallet (m2049r#297) * Fix balance (m2049r#313) * fix length test (m2049r#314) * sweep all (m2049r#317) * French Strings updated to m2049r#297 (m2049r#316) + Missing update to m2049r#312 + enhancement on "wrapping things up" * Fixes to v1.5.5 (m2049r#318) * fix disappearing hamburger * german fixes to fit space * Layout tweaks (m2049r#319) * remove mixin settings (m2049r#320) * subaddresses (m2049r#322) * new subaddress bump effect (m2049r#327) * Update Translations (m2049r#329) * avoid NPE (m2049r#330) * fix displayed subaddress # * fix path of build script * cleanup translations & resources * include for aeon
crtlib
pushed a commit
to evocodes/loki-android-wallet
that referenced
this pull request
Jun 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.