Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enables testing features:
EXIT_SUCCESS
orEXIT_FAILURE
depending on whether the number of converged eigenvalues is less than the number of requested eigenvalues.ENABLE_EXAMPLES
was renamed toENABLE_TESTS
and tests are configured inexamples/CMakeLists.txt
.I compared the Github and Travis logs for the Mac OS build. Both use
I haven't enabled ctest on Travis, but using the default BLAS/LAPACK provider (Accelerate.framework) some tests on the Github workflow failed (see https://github.com/wo80/arpackpp/actions/runs/6453199699/job/17516350173). I had to explicitly specify
BLA_VENDOR=OpenBLAS
andCMAKE_PREFIX_PATH="/usr/local/opt/lapack;/usr/local/opt/openblas"
.So in case you don't want to ditch the Travis job completely, it needs to be updated accordingly. Not sure what's the cause of the problem, though. Since I don't have a Mac, I cannot debug it.