-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix edit theme dialog layout again #2192
Conversation
Ensures that the layout looks better and doesn't get out of place in the smallest windows and largest fonts, as well as in both English and Chinese environments.
This always increases the bottom height. In fact, I hope to avoid scroll bars as much as possible. We may consider automatic line wrapping. |
This issue seems to have arisen in the last PR: #2188
How do we do that? I've tried changing the style many times, but it works worse than it currently does. |
Try this |
LGTM. 🎉 Smaller window and oversize font, use Segoe UI. Some fonts cause scrollbars to persist (e.g. Source Han Serif), and I don't know why, but most other fonts look fine. 🤔 |
Try again |
This is reasonable, all we need to do is prevent the UI from being accidentally cut off. |
Ensures that the layout looks better and doesn't get out of place in the smallest windows and largest fonts, as well as in both English and Chinese environments.
🟢 Before
💙 After