Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix edit theme dialog layout again #2192

Merged
merged 4 commits into from
Dec 21, 2024

Conversation

3gf8jv4dv
Copy link
Contributor

Ensures that the layout looks better and doesn't get out of place in the smallest windows and largest fonts, as well as in both English and Chinese environments.

🟢 Before

lx-music-desktop-edit-theme-dialog-1-1
lx-music-desktop-edit-theme-dialog-1-2
lx-music-desktop-edit-theme-dialog-1-3
lx-music-desktop-edit-theme-dialog-1-4

💙 After

lx-music-desktop-edit-theme-dialog-2-1
lx-music-desktop-edit-theme-dialog-2-2
lx-music-desktop-edit-theme-dialog-2-3
lx-music-desktop-edit-theme-dialog-2-4

Ensures that the layout looks better and doesn't get out of place in the
smallest windows and largest fonts, as well as in both English and
Chinese environments.
@lyswhut
Copy link
Owner

lyswhut commented Dec 19, 2024

This always increases the bottom height. In fact, I hope to avoid scroll bars as much as possible. We may consider automatic line wrapping.

@3gf8jv4dv
Copy link
Contributor Author

In fact, I hope to avoid scroll bars as much as possible.

This issue seems to have arisen in the last PR: #2188

We may consider automatic line wrapping.

How do we do that? I've tried changing the style many times, but it works worse than it currently does.

@lyswhut
Copy link
Owner

lyswhut commented Dec 20, 2024

Try this

@3gf8jv4dv
Copy link
Contributor Author

3gf8jv4dv commented Dec 20, 2024

Try this

LGTM. 🎉


Smaller window and oversize font, use Segoe UI.
If this extreme case is not considered, then this can be merged as soon as possible. 🥰

Preview

1


Some fonts cause scrollbars to persist (e.g. Source Han Serif), and I don't know why, but most other fonts look fine. 🤔

Segoe UI, oversize window and font size

2

Source Han Serif, oversize window and font size

3

@lyswhut
Copy link
Owner

lyswhut commented Dec 21, 2024

If this extreme case is not considered, then this can be merged as soon as possible. 🥰
Some fonts cause scrollbars to persist (e.g. Source Han Serif), and I don't know why, but most other fonts look fine. 🤔

Try again

@3gf8jv4dv
Copy link
Contributor Author

Try again

The first issue is resolved!

Preview

1

The second issue is still there, and I'm personally pessimistic about it — i.e. it's probably not going to be resolved on our end. I don't know what your views are on this.

@lyswhut
Copy link
Owner

lyswhut commented Dec 21, 2024

This is reasonable, all we need to do is prevent the UI from being accidentally cut off.

@lyswhut lyswhut merged commit 4a174c0 into lyswhut:dev Dec 21, 2024
1 check passed
@3gf8jv4dv 3gf8jv4dv deleted the fix-edit-theme-dialog branch December 21, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants