Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix text mistake in desktop lyrics opacity button #2158

Closed
wants to merge 1 commit into from
Closed

Fix text mistake in desktop lyrics opacity button #2158

wants to merge 1 commit into from

Conversation

3gf8jv4dv
Copy link
Contributor

Why are the two swapped :(

@lyswhut
Copy link
Owner

lyswhut commented Dec 9, 2024

Because increasing transparency makes it more transparent,
conversely, it can be called reducing opacity.🤣
What do you think?

@3gf8jv4dv
Copy link
Contributor Author

Ah, my bad.
Now I am reacting. Transparency and opacity are antonyms :(((

@3gf8jv4dv 3gf8jv4dv closed this Dec 9, 2024
@3gf8jv4dv 3gf8jv4dv deleted the desktop_lyric_opacity-fix branch December 9, 2024 15:03
@lyswhut
Copy link
Owner

lyswhut commented Dec 9, 2024 •
edited
Loading

This should be a key naming problem:

-desktop_lyric__opacity_decrease
+desktop_lyric__transparent_decrease

-desktop_lyric__opacity_increase
+desktop_lyric__transparent_increase

@3gf8jv4dv
Copy link
Contributor Author

I agree that.

@lyswhut
Copy link
Owner

lyswhut commented Dec 9, 2024

You can fix it

@3gf8jv4dv
Copy link
Contributor Author

I will do that when I have free time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@3gf8jv4dv @lyswhut