Fix/enable padding #950
Merged
Fix/enable padding #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It happens that the QualityManager is enabled after a forced layer is set, causing an unexpected padding generator behaviour which goes to crazy levels
ex.
room.addEventListener('stream-subscribed', function(streamEvent) {
var stream = streamEvent.stream;
stream._setStaticQualityLayer(0,2);
});
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Seems that if we call setStaticQualityLayer(desired spatial, desired temporal) with wrong timing
ex. immediately after subscribing
this produces an unexpected behaviour:
we receive the selected spatial and temporal layer, but if we inspect the webrtc stats we see that the padding generator goes crazy and send us tons of padding traffic
[] It needs and includes Unit Tests
[] It includes documentation for these changes in
/doc.