Fix/padding removal handler #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcague
approved these changes
Apr 24, 2017
| if (translator_it != translator_map_.end()) { | ||
| ELOG_DEBUG("Found Translator for %u, %s", ssrc, connection_->toLog()); | ||
| translator = translator_it->second; | ||
| } else { |
There was a problem hiding this comment.
} else if (should_create) {?
| void RtpPaddingRemovalHandler::notifyUpdate() { | ||
| auto pipeline = getContext()->getPipelineShared(); | ||
| if (!pipeline) { | ||
| return; | ||
| } | ||
|
|
||
| connection_ = pipeline->getService<WebRtcConnection>().get(); |
There was a problem hiding this comment.
consider moving this line below, after the if(initialized_)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes
PaddingRemovalHandler. It adds sequence number translation for NACKs to avoid problems when there is Padding in non-simulcast connections. Also, the handler is moved in the pipeline to avoid conflicts withFeedbackGenerationHandler[] It needs and includes Unit Tests
Changes in Client or Server public APIs
[] It includes documentation for these changes in
/doc.