Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ExternalOutput with Simulcast #866

Merged
merged 1 commit into from
Apr 21, 2017

Conversation

jcague
Copy link
Contributor

@jcague jcague commented Apr 21, 2017

Description

Fix ExternalOutput with Simulcast. It now gets the lower quality layer, which is sub-optimal. But having a better solution would involve:

  • Implement a pipeline in ExternalOutput to detect quality layers and filter packets.
  • Connect two ErizoJS (one acting as a pure MCU and another recording the stream).

[] It needs and includes Unit Tests

Changes in Client or Server public APIs

Not needed.

[] It includes documentation for these changes in /doc.

Copy link
Contributor

@lodoyun lodoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think it's a good compromise until ExternalOutput can be refactored

@jcague jcague merged commit 9668b17 into lynckia:master Apr 21, 2017
Arri98 pushed a commit to Arri98/licode that referenced this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants