fix stream status after successfuly adding external input #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stream status was not set to PUBLISHER_READY causing erizo controller not include the stream on stream list after room connection success.
Arri98
pushed a commit
to Arri98/licode
that referenced
this pull request
Apr 6, 2021
Stream status was not set to PUBLISHER_READY causing erizo controller not include the stream on stream list after room connection success.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stream status was not set to PUBLISHER_READY causing erizo controller not include the stream on the stream list after a room connection, causing clients not being able to subscribe if they weren't already on the room.
[] It needs and includes Unit Tests
It needs but doesn't include, couldn't find erizo controller tests checking PUBLISHER_READY status in other scenarios, I guess it's the way the RPC calls are tested that makes it complex to test?. Also would be helpful a mini-guide about how to run the full test suite, or just some components. I am running them as I figured out but I am sure there is better way to do it.
No public API changes.
[] It includes documentation for these changes in
/doc.