Fix/device id firefox #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcague
requested changes
Apr 17, 2017
.gitignore
Outdated
| @@ -17,3 +17,4 @@ erizo_controller/erizoAgent/erizo-*.log | |||
| spine/erizofc.js | |||
| extras/basic_example/public/assets/ | |||
| rtp_media_config.js | |||
| .idea | |||
There was a problem hiding this comment.
please remove this line as we don't use .idea files in the main repository.
added 2 commits
April 18, 2017 08:47
|
@jcague done! |
Arri98
pushed a commit
to Arri98/licode
that referenced
this pull request
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tested in Chrome > v.57 & Firefox > v.44
Hi guys,
I had some issues with the deviceId constraint in Erizo.Stream(config). When I want to select a specific deviceId, I had two different behaviour in Chrome and Firefox.
Chrome:
The above code make the following request: (chrome://webrtc-internals)
{deviceId: {ideal: ["78e1b1db6a8c0ddd9b2e4d7758cef70cce62c7f1d0987e6f079360fac2cef41e"]}}The same code in Firefox doesn't seem to work. The deviceId is not specified in the GUM.
I fix the bug using a standard structure to specify the sourceId either in Chrome or Firefox.
{audio: true, video: {mandatory: {sourceId: "123456789"}}}The above code make the following request: (chrome://webrtc-internals)
{deviceId: {exact: ["78e1b1db6a8c0ddd9b2e4d7758cef70cce62c7f1d0987e6f079360fac2cef41e"]}}It works in Firefox as well.
[] It needs and includes Unit Tests
[] It includes documentation for these changes in
/doc.