Add RoomId option to quality layers #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aalonsog
approved these changes
Mar 22, 2017
| @@ -1,5 +1,5 @@ | |||
| # Set root logger level to DEBUG and its only appender to A1. | |||
| log4j.rootLogger=DEBUG, A1 | |||
| log4j.rootLogger=INFO, A1 | |||
There was a problem hiding this comment.
Do you want to change the log level in this PR?
There was a problem hiding this comment.
yes, it's an intentional change because I don't think we need to enable DEBUG level by default. But I can do it in a separate PR if we prefer.
There was a problem hiding this comment.
It's ok for me. Just to check it was't a mistake :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a new option to quality layers to load info from a known room Id.
[] It needs and includes Unit Tests
Changes in Client or Server public APIs
Not needed.
[] It includes documentation for these changes in
/doc.