Added the possibility of dynamically creating p2p rooms in basic example #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcague
approved these changes
Mar 17, 2017
| }; | ||
|
|
||
| createToken('user', 'presenter', roomName, function (response) { | ||
| var room_data = {username: 'user', role: 'presenter', room: roomName, type: roomType}; |
extras/basic_example/basicServer.js
Outdated
| callback(theRoom); | ||
| return; | ||
| } | ||
| } | ||
| N.API.createRoom(roomName, function (roomID) { | ||
|
|
||
| let extra = {data: {basicExampleRoom:true}}; |
|
|
||
| var getOrCreateRoom = function (roomName, callback) { | ||
| var getOrCreateRoom = function (name, type = 'erizo', callback) { |
There was a problem hiding this comment.
why not callback = function(){} too?
| var username = req.body.username, | ||
| role = req.body.role; | ||
| if (req.body.room && !isNaN(req.body.room)) room = req.body.room; | ||
| if (req.body.type) type = req.body.type; |
There was a problem hiding this comment.
Could we use something like:
let room = req.body.room || defaultRoomName;
let type = req.body.type;
or even:
let {body: {room = defaultRoomName, type}} = req;
😄
There was a problem hiding this comment.
We have to check that req.body.room is an integer (!isNaN(req.body.room)). So I'm not sure if just a line is recommended (because probably is possible :D)
Arri98
pushed a commit
to Arri98/licode
that referenced
this pull request
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now you can specify the room type when dynamically creating rooms in basic example. Connecting to
https://basic_server:3004/?room=1234&type=p2pcreates a p2p room called '1234'.[] It needs and includes Unit Tests
Changes in Client or Server public APIs
No changes
[] It includes documentation for these changes in
/doc.