Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hardware disconnection event #779

Merged
merged 6 commits into from
Apr 19, 2017
Merged

hardware disconnection event #779

merged 6 commits into from
Apr 19, 2017

Conversation

kekkokk
Copy link
Contributor

@kekkokk kekkokk commented Feb 23, 2017

Description

This PR link an event (stream-ended) to the track.onended function in each mediastreamtrack to notify the client library that a track is ended prematurely and let the user logic to act accordingly.

Is emitted only once in the life of the stream (es. If both audio and video end, only the first is notified)

Add a short description here, please.

emit stream-ended event on a prematurely end of a mediastreamtrack

[] It needs and includes Unit Tests

Changes in Client or Server public APIs

client API now have a new streamEvent ("stream-ended")

[x] It includes documentation for these changes in /doc.

kekkokk and others added 5 commits February 23, 2017 13:06
… each mediastreamtrack to notify the client library that a track is ended prematurely and let the user logic to act accordingly.

Is emitted only once in the life of the stream (es. If both audio and video end, only the first is notified)
Copy link
Contributor

@jcague jcague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jcague jcague merged commit 0a0ebb1 into lynckia:master Apr 19, 2017
@kekkokk kekkokk deleted the hw_disconnection branch April 19, 2017 09:32
@kekkokk kekkokk restored the hw_disconnection branch May 11, 2017 13:14
@kekkokk kekkokk deleted the hw_disconnection branch May 11, 2017 13:21
Arri98 pushed a commit to Arri98/licode that referenced this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants