Handler to filter packets from higher quality layers #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lodoyun
approved these changes
Feb 23, 2017
|
|
||
| void QualityFilterHandler::handleFeedbackPackets(std::shared_ptr<dataPacket> packet) { | ||
| RtpUtils::forEachRRBlock(packet, [this](RtcpHeader *chead) { | ||
| RtpUtils::updateREMB(chead, 400000); |
There was a problem hiding this comment.
Why 400000? Even if we have proper feedback soon, it probably would make more sense to use maxVideoBW here
| namespace erizo { | ||
|
|
||
| class RtpUtils { | ||
| public: | ||
| static bool sequenceNumberLessThan(uint16_t first, uint16_t second); | ||
|
|
||
| static void forEachRRBlock(std::shared_ptr<dataPacket> packet, std::function<void(RtcpHeader*)> f); |
| checkSSRCChange(ssrc); | ||
| rtp_header->setSSRC(video_sink_ssrc_); | ||
|
|
||
| if (packet->compatible_spatial_layers.back() == target_spatial_layer_ && packet->ending_of_layer_frame) { |
There was a problem hiding this comment.
If I understand this right, if we put this after current line 95, we won't be setting the marker for packets that we're going to discard anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new handler to drop packets that belong to spatial/temporal layers that we don't want to forward to the subscribers.
Changes in the Client API
It also adds a mechanism to choose the spatial and temporal layer from the client (stream._setQualityLayer(...)). The method is prefixed with underscore because the feature is not finished yet and we don't want people to start using it in production yet.
I'll update client's documentation once we make the API public.