Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix google closure compiler for macosx #1877

Merged
merged 13 commits into from
Mar 23, 2023

Conversation

lodoyun
Copy link
Contributor

@lodoyun lodoyun commented Mar 22, 2023

Description

The version we were using of the google-closure-compiler crashed in Mac OS X ventura because of an issue with a dependency - upx

This PR updates it to a more recent version resolving the issue.

[] It needs and includes Unit Tests

Changes in Client or Server public APIs

[] It includes documentation for these changes in /doc.

@lodoyun lodoyun requested a review from Arri98 March 22, 2023 09:41
Copy link
Contributor

@Arri98 Arri98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on MacOSX Ventura and compiles without errors.

@lodoyun lodoyun merged commit a69387e into lynckia:master Mar 23, 2023
@lodoyun lodoyun deleted the fix/google-closure-compiler-macosx branch March 23, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants