Add Backoff and ramp up periods in padding manager #1741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcague
approved these changes
Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces improved backoff and ramp up periods for
RtpPaddingMangerHandler, the goal is for the manager to avoid congesting the network whenever possible.It only takes into account differences in bandwidth estimation. If the estimation decreases, it is detected as potential network problems and padding will stop for some time. After that backoff period, it will gradually ramp up (if the estimation does not decrease again) until it sends the calculated
target_padding_bitrate.Changes in Client or Server public APIs
[] It includes documentation for these changes in
/doc.