Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust bandwidth estimation stats for stream priority distributor #1712

Merged
merged 3 commits into from
May 19, 2021
Merged

Adjust bandwidth estimation stats for stream priority distributor #1712

merged 3 commits into from
May 19, 2021

Conversation

lodoyun
Copy link
Contributor

@lodoyun lodoyun commented May 18, 2021

Description

This PR improves the use of stats in StreamPriorityBandwidthDistributor by:

  1. Updating the stats stored in MediaStream more often (every 100ms at most)
  2. Improving the stats stored in MediaStream so not only the last 500ms are taken into account but using the highest value for each second inside the 3 second window we are currently using
  3. Adding to the calculated desired bitrate the same offset used in QualityManager

This PR also updates the tests accordingly.

[] It needs and includes Unit Tests

Changes in Client or Server public APIs

[] It includes documentation for these changes in /doc.

jcague
jcague approved these changes May 18, 2021
View reviewed changes
Copy link
Contributor

@jcague jcague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lodoyun lodoyun merged commit 71fb501 into lynckia:master May 19, 2021
@lodoyun lodoyun deleted the fix/bwDistributionAlgorithmBweData branch May 19, 2021 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcague jcague jcague approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lodoyun @jcague