Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Safari publish problem #1703

Merged
merged 2 commits into from
Apr 27, 2021
Merged

Fix Safari publish problem #1703

merged 2 commits into from
Apr 27, 2021

Conversation

vpoddubchak
Copy link
Contributor

After this commit Safari start to have problems with publishing.
As I understand, the same problem was with Firefox and it has been fixed.

I did the same for Safari and it works in our environment.

lodoyun
lodoyun reviewed Apr 27, 2021
View reviewed changes
Copy link
Contributor

@lodoyun lodoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I think this is a good solution 👍.
Please fix the linter issues. I think it's only the one I commented.
Thanks!

erizo_controller/erizoClient/src/webrtc-stacks/SafariStack.js Outdated Show resolved Hide resolved
lodoyun
lodoyun approved these changes Apr 27, 2021
View reviewed changes
Copy link
Contributor

@lodoyun lodoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lodoyun lodoyun merged commit 4f57663 into lynckia:master Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lodoyun lodoyun lodoyun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vpoddubchak @lodoyun