Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stats about erizoJS event loop lag #1674

Merged
merged 2 commits into from
Jan 18, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions erizo_controller/ROV/rovMetricsGatherer.js
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,13 @@ class RovMetricsGatherer {
connectionQualityLow: new promClient.Gauge({ name: this.getNameWithPrefix('connection_quality_low'), help: 'connections with low quality' }),
totalPublishersInErizoJS: new promClient.Gauge({ name: this.getNameWithPrefix('total_publishers_erizojs'), help: 'total active publishers in erizo js' }),
totalSubscribersInErizoJS: new promClient.Gauge({ name: this.getNameWithPrefix('total_subscribers_erizojs'), help: 'total active subscribers in erizo js' }),
maxMinEventLoopLag: new promClient.Gauge({ name: this.getNameWithPrefix('event_loop_lag_max_min'), help: 'Min event loop lag' }),
maxMaxEventLoopLag: new promClient.Gauge({ name: this.getNameWithPrefix('event_loop_lag_max_max'), help: 'Max event loop lag' }),
maxMeanEventLoopLag: new promClient.Gauge({ name: this.getNameWithPrefix('event_loop_lag_max_mean'), help: 'Mean event loop lag' }),
maxStdDevEventLoopLag: new promClient.Gauge({ name: this.getNameWithPrefix('event_loop_lag_max_stddev'), help: 'Standard Deviation event loop lag' }),
maxMedianEventLoopLag: new promClient.Gauge({ name: this.getNameWithPrefix('event_loop_lag_max_median'), help: 'Median event loop lag' }),
maxP95EventLoopLag: new promClient.Gauge({ name: this.getNameWithPrefix('event_loop_lag_max_p95'), help: 'Percentile 95 event loop lag' }),
maxP99EventLoopLag: new promClient.Gauge({ name: this.getNameWithPrefix('event_loop_lag_max_p99'), help: 'Percentile 99 event loop lag' }),
};
this.log = logger;
this.releaseInfoRead = false;
Expand Down Expand Up @@ -193,6 +200,39 @@ class RovMetricsGatherer {
return Promise.resolve();
}

getNodeJSEventLoopLag() {
this.log.debug('Getting NodeJSEventLoopLag');
return this.rovClient.runInComponentList('console.log(JSON.stringify(context.computeEventLoopLags()))', this.rovClient.components.erizoJS)
.then((results) => {
let maxMin = 0;
let maxMax = 0;
let maxMean = 0;
let maxStdDev = 0;
let maxMedian = 0;
let maxP95 = 0;
let maxP99 = 0;
results.forEach((data) => {
const result = JSON.parse(data);
maxMin = Math.max(result.min, maxMin);
maxMax = Math.max(result.max, maxMax);
maxMean = Math.max(result.mean, maxMean);
maxStdDev = Math.max(result.stddev, maxStdDev);
maxMedian = Math.max(result.median, maxMedian);
maxP95 = Math.max(result.p95, maxP95);
maxP99 = Math.max(result.p99, maxP99);
});
this.log.debug(`Max Mean Event Loop Lags: ${maxMean}`);
this.prometheusMetrics.maxMinEventLoopLag.set(maxMin);
this.prometheusMetrics.maxMaxEventLoopLag.set(maxMax);
this.prometheusMetrics.maxMeanEventLoopLag.set(maxMean);
this.prometheusMetrics.maxStdDevEventLoopLag.set(maxStdDev);
this.prometheusMetrics.maxMedianEventLoopLag.set(maxMedian);
this.prometheusMetrics.maxP95EventLoopLag.set(maxP95);
this.prometheusMetrics.maxP99EventLoopLag.set(maxP99);
return Promise.resolve();
});
}

getErizoJSMetrics() {
this.log.debug('Getting total connections failed');
return this.rovClient.runInComponentList('console.log(JSON.stringify(context.getAndResetMetrics()))', this.rovClient.components.erizoJS)
Expand Down Expand Up @@ -306,6 +346,7 @@ class RovMetricsGatherer {
.then(() => this.getTotalClients())
.then(() => this.getTotalPublishersAndSubscribers())
.then(() => this.getActiveProcesses())
.then(() => this.getNodeJSEventLoopLag())
.then(() => this.getErizoJSMetrics());
}
}
Expand Down
2 changes: 1 addition & 1 deletion erizo_controller/ROV/rovMetricsServer.js
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ amqper.connect(() => {
log.debug('Gathered licode metrics');
})
.catch((error) => {
log.error('Error gathering metrics', error);
log.error('Error gathering metrics', error.message);
});
}, config.rov.statsPeriod);
server.get('/metrics', (req, res) => {
Expand Down
16 changes: 15 additions & 1 deletion erizo_controller/erizoJS/erizoJSController.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/* global require, exports, setInterval, clearInterval, Promise */


const perfHooks = require('perf_hooks');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

const logger = require('./../common/logger').logger;
const amqper = require('./../common/amqper');
const RovReplManager = require('./../common/ROV/rovReplManager').RovReplManager;
Expand Down Expand Up @@ -34,6 +34,10 @@ exports.ErizoJSController = (erizoJSId, threadPool, ioThreadPool) => {
lastOperation: 0,
};

// For perf metrics
const histogram = perfHooks.monitorEventLoopDelay({ resolution: 10 });
histogram.enable();

const checkUptimeStats = () => {
const now = new Date();
const timeSinceStart = now.getTime() - uptimeStats.startTime.getTime();
Expand Down Expand Up @@ -733,5 +737,15 @@ exports.ErizoJSController = (erizoJSId, threadPool, ioThreadPool) => {
return metrics;
};

that.computeEventLoopLags = () => ({
min: histogram.min / 1e9,
max: histogram.max / 1e9,
mean: histogram.mean / 1e9,
stddev: histogram.stddev / 1e9,
median: histogram.percentile(50) / 1e9,
p95: histogram.percentile(90) / 1e9,
p99: histogram.percentile(99) / 1e9,
});

return that;
};