Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove FuturesManager #1632

Merged
merged 1 commit into from
Sep 15, 2020
Merged

Remove FuturesManager #1632

merged 1 commit into from
Sep 15, 2020

Conversation

lodoyun
Copy link
Contributor

@lodoyun lodoyun commented Sep 15, 2020

Description

This PR removes FuturesManager since we are using a different mechanism to clean up the futures.

[] It needs and includes Unit Tests

Changes in Client or Server public APIs

[] It includes documentation for these changes in /doc.

jcague
jcague approved these changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@jcague jcague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@lodoyun lodoyun merged commit 1b95307 into lynckia:master Sep 15, 2020
@lodoyun lodoyun deleted the fix/futuresManager branch September 15, 2020 12:24
Arri98 pushed a commit to Arri98/licode that referenced this pull request Apr 6, 2021
@lodoyun
Remove FuturesManager (lynckia#1632)
6f2e1ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcague jcague jcague approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lodoyun @jcague