Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SR info to algorithm in ConnectionQualityCheck #1599

Merged

Conversation

jcague
Copy link
Contributor

@jcague jcague commented Jun 9, 2020

Description

We now only measure the fraction lost in the subscriber's path, by subtracting the fraction lost measured in the publisher's side when calculating it in ConnectionQualityCheck.

  • It needs and includes Unit Tests

Changes in Client or Server public APIs

Not needed.

[] It includes documentation for these changes in /doc.

Copy link
Contributor

@lodoyun lodoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I think it's a good way to solve this 👍

@jcague jcague merged commit 696f926 into lynckia:master Jun 12, 2020
@jcague jcague deleted the fix/fix_cases_connection_quality_check branch June 12, 2020 07:21
Arri98 pushed a commit to Arri98/licode that referenced this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants