Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unsubscribe from the last stream in a connection #1401

Merged
merged 1 commit into from
Apr 25, 2019

Conversation

lodoyun
Copy link
Contributor

@lodoyun lodoyun commented Apr 24, 2019

Description

This PR fixes an issue that caused unsubscribes to the last stream in a connection to create a never ending loop of calls to removeStream.

[] It needs and includes Unit Tests

Changes in Client or Server public APIs

[] It includes documentation for these changes in /doc.

Copy link
Contributor

@jcague jcague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! 😉

@lodoyun lodoyun merged commit 2aeefd4 into lynckia:master Apr 25, 2019
@lodoyun lodoyun deleted the fix/unsubscribeFromLastStream branch October 3, 2019 11:16
Arri98 pushed a commit to Arri98/licode that referenced this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants