-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ExtensionId translator #1400
add ExtensionId translator #1400
Conversation
Yes, I had the same problem. The extension IDs are not always the same between each clients, especially between firefox and chrome. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good, I like the idea and the implementation. Just a couple of comments, one does cause issues in my tests.
Thanks!
Co-Authored-By: lidedongsn <dongshining1990@gmail.com>
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ I think extension with 1 byte padding will cause error. According to https://tools.ietf.org/html/rfc5285#section-4.2 |
fix issue #1393 #1399
add ExtensionId translator
Publisher: translate external ExtensionId into internal ExtensionId
Subscriber:translate internal ExtensionId into external ExtensionId