Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ExtensionId translator #1400

Merged
merged 5 commits into from
Apr 29, 2019
Merged

add ExtensionId translator #1400

merged 5 commits into from
Apr 29, 2019

Conversation

lidedongsn
Copy link
Contributor

fix issue #1393 #1399
add ExtensionId translator
Publisher: translate external ExtensionId into internal ExtensionId
Subscriber:translate internal ExtensionId into external ExtensionId

@paul-maxime
Copy link

Yes, I had the same problem. The extension IDs are not always the same between each clients, especially between firefox and chrome.
Translating them like the payload IDs is a nice solution.

Copy link
Contributor

@lodoyun lodoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, I like the idea and the implementation. Just a couple of comments, one does cause issues in my tests.
Thanks!

erizo/src/erizo/MediaStream.cpp Outdated Show resolved Hide resolved
erizo/src/erizo/rtp/RtpExtensionProcessor.h Outdated Show resolved Hide resolved
erizo/src/erizo/MediaStream.cpp Show resolved Hide resolved
erizo/src/erizo/MediaStream.cpp Outdated Show resolved Hide resolved
lodoyun and others added 2 commits April 29, 2019 17:33
Co-Authored-By: lidedongsn <dongshining1990@gmail.com>
@lodoyun lodoyun merged commit ce1f09a into lynckia:master Apr 29, 2019
alokp pushed a commit to MModal/licode that referenced this pull request Apr 29, 2019
@zhangshishen
Copy link

   0                   1                   2                   3
   0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1

+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
| 0xBE | 0xDE | length=3 |
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
| ID | L=0 | data | ID | L=1 | data...
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
...data | 0 (pad) | 0 (pad) | ID | L=3 |
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
| data |
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+

I think extension with 1 byte padding will cause error. According to https://tools.ietf.org/html/rfc5285#section-4.2

Arri98 pushed a commit to Arri98/licode that referenced this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants