Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Periodic task that checks uptime in erizoJS #1369

Merged
merged 1 commit into from
Feb 25, 2019

Conversation

lodoyun
Copy link
Contributor

@lodoyun lodoyun commented Feb 25, 2019

Description

We've detected that there are times where ErizoJS processes won't stop when all publishers leave, causing problems when those processes stay up a long time processing many connections.
We're investigating the issue and will fix the root of the problem.

This PR adds a protection for this problem by checking erizoJS processes that remain up after a long time since the first time they were active. It also makes sure that no new publisher or subscriber has been added recently. These parameters can be adjusted in licode_config.

  • It needs and includes Unit Tests

Changes in Client or Server public APIs

[] It includes documentation for these changes in /doc.

Copy link
Contributor

@jcague jcague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lodoyun lodoyun merged commit 0c34386 into lynckia:master Feb 25, 2019
@kekkokk
Copy link
Contributor

kekkokk commented Feb 26, 2019

I was investigating this a very long time ago and found the issue on this mechanism:
#1241

It's a very old PR but maybe it can help you.

@lodoyun lodoyun deleted the add/erizoJSoverTimeProtection branch February 27, 2019 08:32
Arri98 pushed a commit to Arri98/licode that referenced this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants