Add auto subscriptions API #1361
Conversation
package-lock.json
Outdated
| @@ -0,0 +1,2529 @@ | |||
| { | |||
There was a problem hiding this comment.
Do we want to start version controlling this?
erizo/src/erizo/MediaStream.cpp
Outdated
| stream_found = true; | ||
| } | ||
|
|
||
| if (!stream_found && isPublisher()) { |
There was a problem hiding this comment.
I think we already know isPublisher() is true here.
| return; | ||
| } | ||
|
|
||
| const erizoIds = [...new Set(streamIds.map(streamId => getErizoQueue(streamId)))]; |
There was a problem hiding this comment.
Ugh I don't love spread operations ... I'd prefer Array.from here because it makes it very explicit what we want to get as a result.
It's just a comment though, no need to change it.
There was a problem hiding this comment.
hmmm.... I like that solution too, will change it
|
|
||
| connection.init(knownStreamIds[0], constraints); | ||
| promises.push(connection.createOfferPromise); | ||
| if (options.singlePC) { |
There was a problem hiding this comment.
Since we're creating a single Connection and we're not supporting singlePC for this at this moment. I'd suggest using this parameter (singlePC) to log an error
|
I am running into the following error while doing fresh install in ubuntu-14.04 LTS desktop. My installUbuntuDeps.sh and installNuve.sh is successful without any errors. installErizo.sh is failing with the error. |
This error got fixed after I installed boost version 1.65.0. Looks like install script needs to be updated to handle this. |
Description
This is a work in progress project. The API is being discussed here
Changes in Client or Server public APIs
There will be changes. TBD.
/doc.