Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple minor issues when running Address Sanitizer #1345

Merged
merged 10 commits into from
Jan 29, 2019

Conversation

jcague
Copy link
Contributor

@jcague jcague commented Dec 17, 2018

Description

This PR fixes some warnings and errors that happened while running Address Sanitizer>

  • Remove warnings building Erizo in MacOS Mojave.
  • Fix address sanitizer errors in LayerDetectorHandler.
  • Fix address sanitizer errors in Scheduler.
  • Add an option to build Erizo with Address Sanitizer manually.

[] It needs and includes Unit Tests

Changes in Client or Server public APIs

Not needed.

[] It includes documentation for these changes in /doc.

Copy link
Contributor

@lodoyun lodoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Looks good to me!

@@ -116,12 +116,17 @@ if(COMPILE_EXAMPLES)
endif(COMPILE_EXAMPLES)

## Tests
if(${ERIZO_BUILD_TYPE} STREQUAL "sanitizer")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcague jcague merged commit 2eb262c into lynckia:master Jan 29, 2019
@jcague jcague deleted the fix/multiple_minor_issues branch January 29, 2019 17:03
Arri98 pushed a commit to Arri98/licode that referenced this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants