Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use eslint for nuve #1321

Merged
merged 6 commits into from
Nov 9, 2018
Merged

Use eslint for nuve #1321

merged 6 commits into from
Nov 9, 2018

Conversation

lodoyun
Copy link
Contributor

@lodoyun lodoyun commented Oct 24, 2018

Description

This PR removes all uses for jshint, now eslint (airbnb) is used for all components. NuveAPI is now fully translated to eslint.

There are still some limitations:

  • NuveClient is not being linted anymore. Big parts were being ignored by jshint anyway and the current format is not very eslint/airbnb friendly. I prefer refactoring it and make it more "modern" in a separate PR and ignore it for the linter in the meantime.
  • Spine was not (and still is not) linted.

[] It needs and includes Unit Tests

Changes in Client or Server public APIs

[] It includes documentation for these changes in /doc.

@lodoyun lodoyun changed the title Add/nuve to eslint Use eslint for nuve Oct 24, 2018
jcague
jcague approved these changes Nov 7, 2018
View reviewed changes
Copy link
Contributor

@jcague jcague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lodoyun lodoyun merged commit e21c150 into lynckia:master Nov 9, 2018
@lodoyun lodoyun deleted the add/NuveToEslint branch November 22, 2018 11:41
Arri98 pushed a commit to Arri98/licode that referenced this pull request Apr 6, 2021
@lodoyun
Use eslint for nuve (lynckia#1321)
0ea71cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcague jcague jcague approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lodoyun @jcague