Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove closed singlePC connection in ErizoClient #1301

Merged
merged 6 commits into from
Sep 20, 2018

Conversation

jcague
Copy link
Contributor

@jcague jcague commented Sep 20, 2018

Description

We weren't removing singlePC that was previously closed in ErizoClient. I also added some other minor fixes I found while debugging this issue.

[] It needs and includes Unit Tests

Not needed.

[] It includes documentation for these changes in /doc.

Copy link
Contributor

@lodoyun lodoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jcague jcague force-pushed the fix/remove_connection_for_spc branch from cfd6c4b to 2b3f05d Compare September 20, 2018 14:36
@jcague jcague merged commit ca97119 into lynckia:master Sep 20, 2018
@jcague jcague deleted the fix/remove_connection_for_spc branch September 20, 2018 15:06
Arri98 pushed a commit to Arri98/licode that referenced this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants