Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues that happened during first trials of Single Peer Connection #1200

Merged
merged 6 commits into from
Apr 18, 2018

Conversation

jcague
Copy link
Contributor

@jcague jcague commented Apr 17, 2018

Description

Bugs fixed in this PR:

  • Firefox not accepting different orders of video/audio medias in the SDP.
  • Wrong SDP directions when using Erizo.
  • Simulcast with Single PC did not work sometimes.

[] It needs and includes Unit Tests

Changes in Client or Server public APIs

Not needed

[] It includes documentation for these changes in /doc.

@jcague
Copy link
Contributor Author

jcague commented Apr 17, 2018

this PR should fix #1197 and #1189

Copy link
Contributor

@lodoyun lodoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@jcague jcague merged commit 45b8096 into lynckia:master Apr 18, 2018
@jcague jcague deleted the fix/single_pc_cases branch April 18, 2018 09:24
@arsenicraghav
Copy link

the single peer connection appears to be working however we are not able to get the remote stream, a black screen shows up when running basic example.

Arri98 pushed a commit to Arri98/licode that referenced this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants