Add/edge support #1151
Merged
Add/edge support #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this force adapterjs to use max bundle and generate a single ufrag for both transceivers.
need to set end-of-candidates in the sdp generated by Licode to avoid the adapterjs timeout. this makes Edge to start ice immediately.
jcague
approved these changes
Feb 20, 2018
| @@ -17,6 +17,7 @@ const BaseStack = (specInput) => { | |||
|
|
|||
| that.pcConfig = { | |||
| iceServers: [], | |||
| bundlePolicy: 'max-bundle', | |||
There was a problem hiding this comment.
have you tested this property with Chrome/Firefox? My only concern is not to break things that are working with the browsers that we currently support.
There was a problem hiding this comment.
this breaks p2p firefox, sorry I forgot to update the pr. this must be moved only in EdgeStack, maybe in a separate pr in the future.
| @@ -68,7 +68,9 @@ function getMediaInfoFromDescription(info, sdp, mediaType) { | |||
|
|
|||
| let ice = info.getICECredentials(mediaType); | |||
| if (ice) { | |||
| media.setICE(new ICEInfo(ice[0], ice[1])); | |||
| const thisIceInfo = new ICEInfo(ice[0], ice[1]); | |||
| thisIceInfo.setEndOfCandidates('end-of-candidates'); | |||
There was a problem hiding this comment.
does this break something in Chrome/Firefox?
There was a problem hiding this comment.
this is bulletproof. Also should speed up the ice process a bit and seems a best practice
There was a problem hiding this comment.
This is breaking things in chrome, local and remote stream turns black after merging this change
apparently firefox doesn't like this in p2p. So will be moved in a separate stack in the future
Arri98
pushed a commit
to Arri98/licode
that referenced
this pull request
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In march will be released this fix:
Edge Support
This allows Licode to support it.
Note: the Edge publisher side in VP8 still sucks, even in p2p.
So for an "usable" environment we have to wait that Edge fixes its vp8 encoder
[] It needs and includes Unit Tests
[] It includes documentation for these changes in
/doc.